feat: add basic auth gateway to helm chart #4318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
simonswine
reviewed
Aug 13, 2025
Comment on lines
+543
to
+547
| location ^~ { | ||
| set $api_prom_push_backend http://{{ include "pyroscope.fullname" .}}.{{ .Release.Namespace }}.svc.{{ .Values.gateway.clusterDomain }}; | ||
| proxy_pass $api_prom_push_backend:{{- .Values.pyroscope.service.port -}}$request_uri; | ||
| proxy_http_version 1.1; | ||
| } |
There was a problem hiding this comment.
This actually needs to be broken down and should make sure to only forward the per service endpoints to the correct micro services. Forwarding all traffic to push endpoint, will not work for read traffic.
A good start is to look at the ingress resource here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added basic auth gateway support using ngnix.
This should address the problem in #2082 . The suggested solution cannot be used if you are not using ngnix controller. We are using a custom ingress controller, so it was essential to run a reverse proxy gateway for basic authentication.
I copied lots of components from the official Loki chart in https://github.com/grafana/loki/tree/main/production/helm/loki
I did not specify each single route in ngnix config file as it was done in Loki chart, just simply forward all traffix to Pyroscope service, except
/health, which is required for pod readiness check.